Rework MACHINE_FEATURES #764
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koenkooi
requested review from
quic-vkraleti,
ricardosalveti,
sbanerjee-quic and
ndechesne
as code owners
|
I strongly suspect we can move more features to qcom-common.inc, like |
lumag
reviewed
Feb 20, 2025
Test jobs for commit 2c449db |
|
As you are adding pci to rb3gen2 here, mind also adding at qcm6490-idp.conf and qcs9100-ride-sx.conf? |
koenkooi
force-pushed
the
koen/machine-features
branch
from
2c449db to
09137fe
Compare
Done. Should this move into the qcom-.inc or stay in the MACHINE.conf? |
Test jobs for commit 09137fe |
I think it is fine to have it at board level for now. |
ricardosalveti
approved these changes
Feb 20, 2025
lumag
approved these changes
Feb 21, 2025
|
I've opened #765 , hopefully it can help with the config unification. |
|
@koenkooi please rebase |
koenkooi
force-pushed
the
koen/machine-features
branch
from
09137fe to
c7376fa
Compare
Done |
Test jobs for commit c7376fa |
lumag
reviewed
Feb 24, 2025
If it's common to all MACHINEs, it should be in qcom-common.inc. Signed-off-by: Koen Kooi <[email protected]>
…_FEATURES These boards have PCIe, so reflect that in MACHINE_FEATURES. Signed-off-by: Koen Kooi <[email protected]>
koenkooi
force-pushed
the
koen/machine-features
branch
from
c7376fa to
f9619d4
Compare
lumag
approved these changes
Feb 24, 2025
Test jobs for commit f9619d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #756, this PR puts all common
MACHINE_FEATURESin qcom-common.inc and addspcito RB3.