fix tracing decorator for span context and baggages #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libourel06
changed the title
llva
reviewed
Feb 26, 2025
| @@ -101,7 +101,7 @@ | |||
| public class TracingDecoratorTest { | |||
| // header value format here: https://www.w3.org/TR/trace-context/#traceparent-header | |||
| private static final String TRACE_PARENT = w3cHeader("1", "9"); | |||
| private static final String PROCESSOR_NAME = MockType.class.getName(); | |||
| private static final String PROCESSOR_NAME = io.quarkiverse.kafkastreamsprocessor.impl.decorator.processor.TracingDecoratorTest.MockType.class.getName(); | |||
There was a problem hiding this comment.
Not really sure to understand why such expanded class path is needed here ...
There was a problem hiding this comment.
yes indeed, it was added automatically by my Intelij. I just removed it, thanks for the notice.
FDPT-69007 fix tracingDecorator for span context, Baggages and header context Update TracingDecoratorTest.java remove automatically added io.quarkiverse.kafkastreamsprocessor.impl.decorator.processor.TracingDecoratorTest prefix to used classes Update TracingDecoratorTest.java adapt unit test to new constructor of TracingDecorator
libourel06
force-pushed
the
FDPT-69007-fix-tracingDecorator-for-span-context-and-baggages
branch
from
dd72080 to
3369984
Compare
|
Indeed, seems this was added automatically by my intelij and i did not
noticed. I removed it, thanks
Le mer. 26 févr. 2025 à 09:59, llva ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In
impl/src/test/java/io/quarkiverse/kafkastreamsprocessor/impl/decorator/processor/TracingDecoratorTest.java
<#146 (comment)>
:
> @@ -101,7 +101,7 @@
public class TracingDecoratorTest {
// header value format here: https://www.w3.org/TR/trace-context/#traceparent-header
private static final String TRACE_PARENT = w3cHeader("1", "9");
- private static final String PROCESSOR_NAME = MockType.class.getName();
+ private static final String PROCESSOR_NAME = io.quarkiverse.kafkastreamsprocessor.impl.decorator.processor.TracingDecoratorTest.MockType.class.getName();
Not really sure to understand why such expanded class path is needed here
...
—
Reply to this email directly, view it on GitHub
<#146 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCFBOGHOU25M5OMIEE4VSL2RV7AJAVCNFSM6AAAAABXX6NCXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBTGY3DCOJQG4>
.
You are receiving this because you authored the thread.Message ID:
<quarkiverse/quarkus-kafka-streams-processor/pull/146/review/2643661907@
github.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go back to old implementation that enables to propagate de Baggages, the spans context (especially the span parent trace Id and trace parent id)