Skip to content

Share even more code between deployment resource decorators#53778

Open
metacosm wants to merge 1 commit intoquarkusio:mainfrom
metacosm:remove-decorators
Open

Share even more code between deployment resource decorators#53778
metacosm wants to merge 1 commit intoquarkusio:mainfrom
metacosm:remove-decorators

Conversation

@metacosm
Copy link
Copy Markdown
Contributor

@metacosm metacosm commented Apr 23, 2026 •
edited by geoand
Loading

Follows up on #53421. Reduces amount of created decorators and removes
now unneeded ones.

@metacosm metacosm self-assigned this Apr 23, 2026
@metacosm metacosm force-pushed the remove-decorators branch from 1304efa to 19e5125 Compare April 23, 2026 19:53
@quarkus-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

🎊 PR Preview 843333f has been successfully built and deployed to https://quarkus-pr-main-53778-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot

This comment has been minimized.

Sign in to view
@metacosm metacosm marked this pull request as draft April 24, 2026 11:04
@metacosm
Copy link
Copy Markdown
Contributor Author

metacosm commented Apr 24, 2026

Realized that I missed a couple of things, so reverting to draft to finalize.

@metacosm metacosm force-pushed the remove-decorators branch from 19e5125 to d36536a Compare April 24, 2026 14:18
@metacosm metacosm force-pushed the remove-decorators branch from d36536a to 5df7c1e Compare April 24, 2026 15:03
@metacosm metacosm mentioned this pull request Apr 24, 2026
Open
@metacosm
Share even more code between deployment resource decorators
1dd2b6c 
Follows up on quarkusio#53421. Reduces amount of created decorators and removes
now unneeded ones.

Fixes quarkusio#53797
@metacosm metacosm force-pushed the remove-decorators branch from 5df7c1e to 1dd2b6c Compare April 24, 2026 15:04
@metacosm metacosm marked this pull request as ready for review April 24, 2026 15:04
@metacosm metacosm mentioned this pull request Apr 24, 2026
Draft
@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Apr 24, 2026

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 1dd2b6c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Apr 24, 2026 •
edited by github-actions Bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1dd2b6c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

geoand
geoand reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Is there anyway we can have a test that covers the original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geoand geoand geoand left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@metacosm metacosm

Labels

area/kubernetes triage/backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

quarkus-openshift emits both Deployment and DeploymentConfig` dual pods spawn in cluster

3 participants

@metacosm @geoand @gsmet