Skip to content

Mark UBI9_JAVA25 as containsJavaRun#53787

Open
tomas1885 wants to merge 1 commit intoquarkusio:mainfrom
tomas1885:jib_java25_ubi_9
Open

Mark UBI9_JAVA25 as containsJavaRun#53787
tomas1885 wants to merge 1 commit intoquarkusio:mainfrom
tomas1885:jib_java25_ubi_9

Conversation

@tomas1885
Copy link
Copy Markdown
Contributor

Adding UBI9_JAVA25 to containerJavaRun in JibProcessor so it would default to the java-run.sh entrypoint.

@tomas1885 tomas1885 changed the title Add UBI9_JAVA25 to containsRunJava so it would use the default run-ja… Mark UBI9_JAVA25 as containsJavaRun Apr 24, 2026
Copy link
Copy Markdown
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thanks for the PR.

I think this is a good sign this approach doesn't scale very well :).

I think we should have a Pattern in ContainerImages that matches all of them and use that. I would even make the -runtime part optional and make sure we support UBI 10 and beyond.

Would you be up for it?

@tomas1885
Copy link
Copy Markdown
Contributor Author

@gsmet I guess it depends on whether UBI 10 plan on supporting java-run.sh no?

@gsmet
Copy link
Copy Markdown
Member

gsmet commented Apr 24, 2026

@tomas1885 yes, I can confirm that I expect all UBI OpenJDK images to contain this script for the foreseeable future thus why I was pushing for a regexp.

@tomas1885
Copy link
Copy Markdown
Contributor Author

@gsmet I think that the -runtime suffix should still be used, otherwise s2i base images would also start using the run-java.sh entrypoint, right now they are not included in the containsJavaRun check, am I missing something?

@gsmet
Copy link
Copy Markdown
Member

gsmet commented Apr 24, 2026

My idea was to catch registry.access.redhat.com/ubi[0-9]+/openjdk-[0-9]+(-runtime)?. So I don't think s2i images would get impacted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Latest LTS and Java 25 - jib container entrypoint changed from run-java.sh regardless of aot or jar type

2 participants