Mark UBI9_JAVA25 as containsJavaRun#53787
Conversation
gsmet
left a comment
There was a problem hiding this comment.
Good catch and thanks for the PR.
I think this is a good sign this approach doesn't scale very well :).
I think we should have a Pattern in ContainerImages that matches all of them and use that. I would even make the -runtime part optional and make sure we support UBI 10 and beyond.
Would you be up for it?
|
@gsmet I guess it depends on whether UBI 10 plan on supporting java-run.sh no? |
|
@tomas1885 yes, I can confirm that I expect all UBI OpenJDK images to contain this script for the foreseeable future thus why I was pushing for a regexp. |
|
@gsmet I think that the -runtime suffix should still be used, otherwise s2i base images would also start using the run-java.sh entrypoint, right now they are not included in the containsJavaRun check, am I missing something? |
|
My idea was to catch |
Adding UBI9_JAVA25 to containerJavaRun in JibProcessor so it would default to the java-run.sh entrypoint.