Skip to content

Make MultiRootPathTree.apply() consistent with accept()#53806

Open
aloubyansky wants to merge 1 commit intoquarkusio:mainfrom
aloubyansky:multi-root-apply-fix
Open

Make MultiRootPathTree.apply() consistent with accept()#53806
aloubyansky wants to merge 1 commit intoquarkusio:mainfrom
aloubyansky:multi-root-apply-fix

Conversation

@aloubyansky
Copy link
Copy Markdown
Member

This change makes MultiRootPathTree.apply() skip calls to wrapped PathTree instances if the visit object is null.
In other words, it calls the target visitor for the first PathTree that actually provides the requested resource.
If the requested resource was not found in any PathTree then the target visitor is called with null visit.

The issue was mentioned in #53791

@aloubyansky
Copy link
Copy Markdown
Member Author

Oh, it breaks tests. I'll fix it.

@quarkus-bot
Copy link
Copy Markdown

quarkus-bot Bot commented Apr 24, 2026

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4cddec1.

Warning

Unable to include the stracktraces as the report was too long. See annotations below for the details.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
Gradle Tests - JDK 25 Build Failures Logs Raw logs 🔍
Gradle Tests - JDK 17 Windows Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Gradle Tests - JDK 25 #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.AnnotationProcessorMultiModuleDevModeTest.main line 13 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicCompositeBuildExtensionProjectDevModeTest.main line 28 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicCompositeBuildProjectDevModeTest.main line 28 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicJavaLibraryModuleDevModeTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicMultiModuleProjectDevModeTest.main line 22 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.ImplementationFilesDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main line 16 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexIncludedBuildTest.main line 19 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexKordampMultiModuleProjectDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexVlsiMultiModuleProjectDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiCompositeBuildExtensionsDevModeTest.main line 27 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleNamedInjectionDevModeTest.main line 21 - History - More details - Source on GitHub


⚙️ Gradle Tests - JDK 17 Windows #

📦 integration-tests/gradle

io.quarkus.gradle.FastJarFormatWorksTest.testFastJarFormatWorks line 39 - History - More details - Source on GitHub

io.quarkus.gradle.LegacyJarFormatWorksTest.testLegacyJarFormatWorks line 38 - History - More details - Source on GitHub

io.quarkus.gradle.MultiModuleUberJarTest.testUberJarForMultiModule line 38 - History - More details - Source on GitHub

io.quarkus.gradle.MutableJarFormatBootsInDevModeTest.testFastJarFormatWorks line 40 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.AnnotationProcessorMultiModuleDevModeTest.main line 13 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.AnnotationProcessorSimpleModuleDevModeTest.main line 13 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.AvroDevModeTest.main line 15 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicCompositeBuildExtensionProjectDevModeTest.main line 28 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicCompositeBuildProjectDevModeTest.main line 28 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicJavaLibraryModuleDevModeTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicJavaPlatformModuleDevModeTest.main line 23 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 19 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.BasicMultiModuleProjectDevModeTest.main line 22 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.CompileOnlyDependencyDevModeTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.CustomJarClassifierDevModeTest.main line 18 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.CustomQuarkusDevModeConfigurationTest.main line 13 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.CustomWorkingDirDevModeTest.main line 18 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.DependencyConstraintsDevModeTest.main line 14 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.DotEnvQuarkusDevModeConfigurationTest.main line 13 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.ImplementationFilesDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.IncludedKotlinBuildDevModeTest.main line 16 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.IncludedKotlinKMPBuildDevModeTest.main line 14 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.InjectQuarkusAppPropertiesDevModeTest.main line 19 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexIncludedBuildTest.main line 19 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexKordampMultiModuleProjectDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.JandexVlsiMultiModuleProjectDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.KotlinMultiplatformModuleDevModeTest.main line 14 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.KotlinProjectWithCompilerArgsDevModeTest.main line 17 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.main line 25 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.ModuleWithParentDependencyDevModeTest.main line 14 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiCompositeBuildExtensionsDevModeTest.main line 27 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleKotlinProjectDevModeTest.main line 23 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleNamedInjectionDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleWithEmptyModuleDevModeTest.main line 22 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiModuleWithNoTestModuleDevModeTest.main line 21 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.MultiSourceProjectDevModeTest.main line 22 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.ResourcesInBuildStepsDevModeTest.main line 24 - History - More details - Source on GitHub

io.quarkus.gradle.devmode.TestSelectionTest.main line 21 - History - More details - Source on GitHub


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/smallrye-reactive-messaging-kafka/deployment

io.quarkus.smallrye.reactivemessaging.kafka.deployment.testing.KafkaDevServicesContinuousTestingWorkingAppPropsTestCase.testContinuousTestingScenario3 - History

  • org.testcontainers.containers.ContainerLaunchException: Container startup failed for image docker.io/library/redis:7 - java.util.concurrent.CompletionException

⚙️ JVM Tests - JDK 25 Semeru

📦 extensions/load-shedding/deployment

io.quarkus.load.shedding.NaiveLoadSheddingTest.test - History

  • Expecting actual: 98 to be greater than or equal to: 100 - java.lang.AssertionError

📦 extensions/quartz/deployment

io.quarkus.quartz.test.PausedSchedulerTest.testSchedulerPauseResume - History

  • expected: <false> but was: <true> - org.opentest4j.AssertionFailedError

  • expected: <false> but was: <true> - org.opentest4j.AssertionFailedError


⚙️ JVM Integration Tests - JDK 17 Windows

📦 integration-tests/smallrye-graphql

io.quarkus.it.smallrye.graphql.MicrometerMetricsTest.shouldCreateMetricsFromAsyncQueryAndAsyncBatch - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: a string containing "mp_graphql_seconds_count{name=\"asyncSuperMetricFoo\",source=\"false\",type=\"QUERY\"}" Actual: \# TYPE http_server_requests_seconds summary \# HELP http_server_requests_seconds HTTP server request processing time - java.lang.AssertionError

⚙️ JVM Integration Tests - JDK 21

📦 integration-tests/reactive-messaging-kafka

io.quarkus.it.kafka.KafkaConnectorTest.testDataForKeyed - History

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <3> but was: <4> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

  • Assertion condition defined as a Lambda expression in io.quarkus.it.kafka.KafkaConnectorTest expected: <3> but was: <6> within 10 seconds. - org.awaitility.core.ConditionTimeoutException

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants