Fix potential NPE and warn if trustall is being used in the exporter#53807
Open
brunobat wants to merge 1 commit intoquarkusio:mainfrom
Open
Fix potential NPE and warn if trustall is being used in the exporter#53807brunobat wants to merge 1 commit intoquarkusio:mainfrom
brunobat wants to merge 1 commit intoquarkusio:mainfrom
Conversation
|
/cc @radcortez (opentelemetry) |
Status for workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis revealed the possibility of some null pointer exceptions (NPE) and an index out of bounds.
Also not warning when
trustallis being used in the exporters connection.Even if it's not the default, it was flagged as a security risk and a warning is now emitted. A test was added to make sure the log line is there.