[4.0] Unix Domain Socket support works without native transports#54917
Merged
Conversation
Member
|
Oh, this is good! |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
The JDK 25 Semeru build failure seems unrelated. Can someone please restart the failed builds? |
jponge
previously approved these changes
Jun 18, 2026
cescoffier
previously approved these changes
Jun 19, 2026
cescoffier
left a comment
Member
There was a problem hiding this comment.
Looks good!
I made a few comments on the testing part.
Closes quarkusio#54528 With Vert.x 5, it's possible to connect or listen to Unix Domain Sockets without native transports, if the runtime version is at least 16+, which is always true for Quarkus. We should clarify in the docs that UDS work in both JVM and native mode, and remove instructions to add native dependencies.
Member
Author
|
@cescoffier PTAL I reworked the tests using a |
This comment has been minimized.
This comment has been minimized.
Member
|
Relaunching the Java 17 job. |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Tests - JDK 21 | Logs | Raw logs | 🚧 | ||
| ✔️ | JVM Tests - JDK 25 | Logs | Raw logs | 🚧 | ||
| ❌ | JVM Tests - JDK 25 Semeru | Build |
Logs | Raw logs | 🚧 |
You can consult the Develocity build scans.
Flaky tests - Develocity
⚙️ JVM Tests - JDK 17
📦 extensions/vertx-http/deployment
❌ io.quarkus.vertx.http.filters.GracefulShutdownFilterTest.test - History
Timeout waiting for response-java.lang.RuntimeException
Details
java.lang.RuntimeException: Timeout waiting for response
at io.quarkus.vertx.http.filters.GracefulShutdownFilterTest.testWithVertxHttpClientAndHttp2AfterShutdown(GracefulShutdownFilterTest.java:85)
at io.quarkus.vertx.http.filters.GracefulShutdownFilterTest.test(GracefulShutdownFilterTest.java:59)
jponge
approved these changes
Jun 19, 2026
|
🙈 The PR is closed and the preview is expired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54528
With Vert.x 5, it's possible to connect or listen to Unix Domain Sockets without native transports, if the runtime version is at least 16+, which is always true for Quarkus.
We should clarify in the docs that UDS work in both JVM and native mode, and remove instructions to add native dependencies.