Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post about testing Quarkus apps with Citrus #1839

Merged

Conversation

christophd
Copy link
Contributor

No description provided.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I added some very small suggestions

@christophd christophd force-pushed the posts/citrus-quarkus-testing branch from b9a97a5 to 0b049f4 Compare November 21, 2023 15:11
@christophd
Copy link
Contributor Author

Many thanks @geoand - just incorporated your suggestions

We will use the Citrus test framework as it provides the complete toolset for testing this kind of event-driven message-based solutions.

The first thing to do is to add Citrus to the Quarkus project.
The most convenient way is to import the `citrus-bom`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the citrus-bom required?

how about getting the citrus-quarkus extension listed on code.quarkus.io?

then hopefully quarkus ext add citrus-quarkus would be sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, better yet, https://hub.quarkiverse.io/checklist/#make-your-extension-available-in-the-tooling (same content as what @geoand shared, but formatted html... the indexing for that content is still a bit poor, but that's a different conversation!).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to list the extension on code.quarkus.io

the citrus-quarkus extension POM does not include all Citrus modules. How would the dependency resolving work in that case when there is no bom imported?

In general the citrus-bom is not required, it only avoids to add the dependency version setting on all included citrus-* modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. @aloubyansky, can you share thoughts on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the platform mechanism makes sense for this scenario: https://quarkus.io/guides/platform ... there would be a Citrus platform, which maps to the Citrus bom. Camel do this now, and there are a few smaller projects that also provide their own platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about adding this extension to the platform at this point.
The text makes sense to me. AFAIU, it's either a BOM or a shared version property.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking more that we would create a new Citrus platform to hold its bom, not add it to the main Quarkus platform.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't do it either, so far we have only one platform in our registry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I'm using the wrong words. I think I mean platform member.

Things like

io.quarkus.platform:quarkus-kogito-bom-quarkus-platform-descriptor
io.quarkus.platform:quarkus-camel-bom-quarkus-platform-descriptor
io.quarkus.platform:quarkus-amazon-services-bom-quarkus-platform-descriptor

@christophd christophd force-pushed the posts/citrus-quarkus-testing branch from 0b049f4 to 9b1ca01 Compare November 21, 2023 18:32
Copy link

github-actions bot commented Nov 22, 2023

🎊 PR Preview 134af65 has been successfully built and deployed to https://quarkus-site-pr-1839-preview.surge.sh

@christophd
Copy link
Contributor Author

@maxandersen @geoand is there still something missing or can we get this published? many thanks

@geoand
Copy link
Contributor

geoand commented Nov 24, 2023

Good to go on my end. @maxandersen @holly-cummins ?

@holly-cummins
Copy link
Contributor

Good to go on my end. @maxandersen @holly-cummins ?

I spotted a few minor grammar nits, but apart from that, looks really good. This is a good addition, thanks @christophd!

(I do think we should pursue figuring out the right path to get the citrus extension listed in the extension, but that shouldn't block the blog; we can just do a minor edit once that's done.)

@maxandersen
Copy link
Member

Good to go. Let's push on Monday after thanksgiving.

@christophd christophd force-pushed the posts/citrus-quarkus-testing branch from 9b1ca01 to f59169e Compare November 24, 2023 21:48
@christophd
Copy link
Contributor Author

Thank you @holly-cummins - these are good findings. Fixed all of them

@maxandersen changed the date of the post to next Monday 27th Nov

Many thanks folks!

@christophd
Copy link
Contributor Author

christophd commented Nov 29, 2023

👋 short reminder to push this one, please

Many thanks!

@maxandersen
Copy link
Member

we have java 17 update going out today so adjusted date and pushing this as Dec 1 post. Thanks @christophd and sorry for the delay.

@maxandersen maxandersen merged commit 134af65 into quarkusio:develop Nov 30, 2023
@christophd
Copy link
Contributor Author

@maxandersen sorry to ask one more time but I do not see the post being published yet. can you see why this is not online already? many thanks

@christophd
Copy link
Contributor Author

@maxandersen Ah, found it! The publish date is wrong. It has been published as of January 12th 2023 instead of December 1st 2023

https://quarkus.io/blog/testing-quarkus-with-citrus/

@geoand
Copy link
Contributor

geoand commented Dec 4, 2023

I am pretty that if you provide a PR fixing that, it will reflected on the blog a few minutes after we merge it

@christophd
Copy link
Contributor Author

@geoand sure thx. #1851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants