-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add post about testing Quarkus apps with Citrus #1839
Add post about testing Quarkus apps with Citrus #1839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, I added some very small suggestions
b9a97a5
to
0b049f4
Compare
Many thanks @geoand - just incorporated your suggestions |
We will use the Citrus test framework as it provides the complete toolset for testing this kind of event-driven message-based solutions. | ||
|
||
The first thing to do is to add Citrus to the Quarkus project. | ||
The most convenient way is to import the `citrus-bom`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the citrus-bom required?
how about getting the citrus-quarkus extension listed on code.quarkus.io?
then hopefully quarkus ext add citrus-quarkus would be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, better yet, https://hub.quarkiverse.io/checklist/#make-your-extension-available-in-the-tooling (same content as what @geoand shared, but formatted html... the indexing for that content is still a bit poor, but that's a different conversation!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to list the extension on code.quarkus.io
the citrus-quarkus extension POM does not include all Citrus modules. How would the dependency resolving work in that case when there is no bom imported?
In general the citrus-bom is not required, it only avoids to add the dependency version setting on all included citrus-*
modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. @aloubyansky, can you share thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the platform mechanism makes sense for this scenario: https://quarkus.io/guides/platform ... there would be a Citrus platform, which maps to the Citrus bom. Camel do this now, and there are a few smaller projects that also provide their own platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about adding this extension to the platform at this point.
The text makes sense to me. AFAIU, it's either a BOM or a shared version property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more that we would create a new Citrus platform to hold its bom, not add it to the main Quarkus platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't do it either, so far we have only one platform in our registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry, I'm using the wrong words. I think I mean platform member.
Things like
io.quarkus.platform:quarkus-kogito-bom-quarkus-platform-descriptor
io.quarkus.platform:quarkus-camel-bom-quarkus-platform-descriptor
io.quarkus.platform:quarkus-amazon-services-bom-quarkus-platform-descriptor
0b049f4
to
9b1ca01
Compare
🎊 PR Preview 134af65 has been successfully built and deployed to https://quarkus-site-pr-1839-preview.surge.sh |
@maxandersen @geoand is there still something missing or can we get this published? many thanks |
Good to go on my end. @maxandersen @holly-cummins ? |
I spotted a few minor grammar nits, but apart from that, looks really good. This is a good addition, thanks @christophd! (I do think we should pursue figuring out the right path to get the citrus extension listed in the extension, but that shouldn't block the blog; we can just do a minor edit once that's done.) |
Good to go. Let's push on Monday after thanksgiving. |
9b1ca01
to
f59169e
Compare
Thank you @holly-cummins - these are good findings. Fixed all of them @maxandersen changed the date of the post to next Monday 27th Nov Many thanks folks! |
👋 short reminder to push this one, please Many thanks! |
we have java 17 update going out today so adjusted date and pushing this as Dec 1 post. Thanks @christophd and sorry for the delay. |
@maxandersen sorry to ask one more time but I do not see the post being published yet. can you see why this is not online already? many thanks |
@maxandersen Ah, found it! The publish date is wrong. It has been published as of January 12th 2023 instead of December 1st 2023 |
I am pretty that if you provide a PR fixing that, it will reflected on the blog a few minutes after we merge it |
No description provided.