Fix "Sorry, no guides matched your search." when starting initial search and missing CSS classes when guide search defaults to Javascript #1911
Merged
Conversation
yrodiere
force-pushed
the
fix-initial-no-results
branch
from
4ac8b8e to
83658aa
Compare
|
😭 Deploy PR Preview failed. |
Member
|
I'm not entirely sure of what's going on but when testing locally, I have |
Member
Author
If you test locally, you also need to launch search.quarkus.io locally. That being said... javascript search should have stepped in :/ I'll have a look. |
yrodiere
force-pushed
the
fix-initial-no-results
branch
from
83658aa to
a3c5436
Compare
yrodiere
changed the title
Member
Author
|
@gsmet should be all good now. I also fixed the problem of missing CSS classes when defaulting to Javascript search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes quarkusio/search.quarkus.io#200