Skip to content

fix: make description consistent with link-external-filter example code #10806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

mcanouil
Copy link
Collaborator

@mcanouil mcanouil commented Sep 16, 2024

The example for the link-external-filter config is confusing because it includes the word "custom" in the regex, which is not explained. This pull request updates the example to clarify that http://www.quarto.org/custom and https://www.quarto.org/custom are treated as internal links, while others are considered external. This resolves #10780.

Companion PR:

@mcanouil mcanouil self-assigned this Sep 16, 2024
@mcanouil mcanouil changed the title fix: Confusing link-external-filter example fix: make description consistent with link-external-filter example code Sep 16, 2024
@cderv cderv requested a review from cscheid September 16, 2024 14:30
@cscheid cscheid added this to the v1.7 milestone Nov 18, 2024
@cscheid cscheid self-assigned this Dec 12, 2024
@cscheid
Copy link
Collaborator

cscheid commented Apr 7, 2025

I don't know what's going on with gh and GitHub, but I can't seem to push to your PR branches and I swear I could in the past. I'm just going to close this and fix from a new branch.

@cscheid cscheid closed this Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing link-external-filter example
2 participants