Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add boilerplate for babylon vault #687

Closed
wants to merge 4 commits into from
Closed

Add boilerplate for babylon vault #687

wants to merge 4 commits into from

Conversation

lubkoll
Copy link
Contributor

@lubkoll lubkoll commented Jul 22, 2024

No description provided.

@lubkoll lubkoll force-pushed the feat/babylon branch 2 times, most recently from 7824ab0 to 246dced Compare July 22, 2024 15:56
@lubkoll lubkoll changed the title WIP: Add boilerplate for babylon vault Add boilerplate for babylon vault Jul 22, 2024
ajansari95
ajansari95 reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ajansari95 ajansari95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can start segregating workspaces based on Product. In here the workspace shouldn't be shared with osmosis contracts

@lubkoll lubkoll requested a review from akure July 23, 2024 09:43
@lubkoll lubkoll force-pushed the feat/babylon branch 5 times, most recently from 067aa07 to 2868390 Compare July 24, 2024 14:28
@lubkoll lubkoll requested a review from arhamchordia July 24, 2024 14:28
@lubkoll lubkoll force-pushed the feat/babylon branch 5 times, most recently from 9d09c39 to 8bb346b Compare July 29, 2024 09:45
@lubkoll
Copy link
Contributor Author

lubkoll commented Sep 10, 2024

Closing the PR for now, keeping the branches. We can reopen that when we actually do it

@lubkoll lubkoll closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajansari95 ajansari95 ajansari95 left review comments

@magiodev magiodev Awaiting requested review from magiodev

@0xLaurenzo 0xLaurenzo Awaiting requested review from 0xLaurenzo

@akure akure Awaiting requested review from akure

@arhamchordia arhamchordia Awaiting requested review from arhamchordia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lubkoll @akure @arhamchordia @ajansari95