remove '.' from @INC #181
Merged
remove '.' from @INC #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the link below: http://search.cpan.org/dist/perl-5.26.0/pod/perldelta.pod#Removal_of_the_current_directory_(%22.%22)_from_@INC Perls before 5.26 include dot in INC unless taint mode is enabled. Most script supplied by quattor does have taint enabled except a few. Here I am using the recommendation to remove dot from @inc. This is safe invocation as if someone enables taint mode or upgrades perl it still does the right thing.
stdweird
reviewed
Dec 17, 2017
| @@ -10,6 +10,7 @@ use warnings; | |||
| # required for CAF | |||
| BEGIN { | |||
| unshift(@INC, '/usr/lib/perl'); | |||
| pop @INC if $INC[-1] eq '.'; | |||
There was a problem hiding this comment.
title should be changed to "only remove '.' when it's the last element in INC".
or replace the BEGIN block with (untested)
BEGIN {
@INC = ('/usr/lib/perl', grep {$_ ne '.'} @INC);
}btw, this should be turned in a template in maven-tools, i made quattor/maven-tools#169
There was a problem hiding this comment.
The idea comes from here (a respected member of the perl community):
https://www.masteringperl.org/2017/01/perl-v5-26-removes-from-inc-but-dont-think-youre-safe/
dot is always last in INC so it should suffice.
There was a problem hiding this comment.
ok, i wasn't sure. can you also open an issue to switch remaining scripts to taint mode, so this isn't forgotten?
stdweird
approved these changes
Dec 17, 2017
ttyS4
added a commit
to quattor/ncm-query
that referenced
this pull request
Jan 24, 2018
This is the same as in quattor/CCM#181
ttyS4
added a commit
to quattor/ncm-query
that referenced
this pull request
Jan 24, 2018
This is the same as in quattor/CCM#181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the link below:
http://search.cpan.org/dist/perl-5.26.0/pod/perldelta.pod#Removal_of_the_current_directory_(%22.%22)_from_@INC
Perls before 5.26 include dot in INC unless taint mode is enabled.
Most script supplied by quattor does have taint enabled except a few.
Here I am using the recommendation to remove dot from
@INC. This is safeinvocation as if someone enables taint mode or upgrades perl it still does the
right thing.