Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove description field #215

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Remove description field #215

merged 1 commit into from
Nov 28, 2024

Conversation

jrha
Copy link
Member

@jrha jrha commented Sep 16, 2024

The ability to set this was removed in pan 8 back in 2008.

This is backwards incompatible as it changes the on-disk DB format.

Based on #214.

@jrha jrha added the cleanup label Sep 16, 2024
@jrha jrha added this to the 25.next milestone Sep 16, 2024
@jrha jrha force-pushed the remove_description branch from 25c67b3 to 800404a Compare September 16, 2024 17:03
The ability to set this was removed in pan 8 back in 2008.

This is backwards incompatible as it changes the on-disk DB format.
@jrha jrha force-pushed the remove_description branch from 800404a to c6febe2 Compare November 27, 2024 17:04
@jrha jrha marked this pull request as ready for review November 27, 2024 17:05
@jrha jrha requested review from stdweird and ned21 November 27, 2024 17:28
Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we ensure that upgrading ccm calls ccm-fetch --force (e.g. as part of rpm post-upgrade script) to force rewrite of on disk files?

@jrha
Copy link
Member Author

jrha commented Nov 28, 2024

Yep ccm-fetch -f was added in #214.

@jrha jrha merged commit 119241d into quattor:master Nov 28, 2024
1 check passed
@jrha jrha deleted the remove_description branch November 28, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants