Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export archetype/os as a dict in hostdata template #94

Closed
wants to merge 1 commit into from
Closed

Export archetype/os as a dict in hostdata template #94

wants to merge 1 commit into from

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Jun 4, 2018

  • Requires archetype_os_dict=true in aqd.conf (default: false)
  • Required for template libary >= 17.7.0 support

Fixes #93

Change-Id: Ibfb52dc616209dfd892449e572f95499f4ee6737

@jouvin
Export archetype/os as a dict in hostdata template
76660a0 
- Requires archetype_os_dict=true in aqd.conf (default: false)
- Required for template libary >= 17.7.0 support

Fixes quattor#93

Change-Id: Ibfb52dc616209dfd892449e572f95499f4ee6737
@jouvin jouvin requested review from ned21, jrha and urbonegi June 4, 2018 10:35
jrha
jrha approved these changes Jun 4, 2018
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ned21
ned21 requested changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@ned21 ned21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it looks like the earlier template change should not have changed this field since it was already in use by the broker. We need to revisit that schema change, not change the broker.

@jouvin jouvin mentioned this pull request Jun 5, 2018
Merged
@jrha
Copy link
Member

jrha commented Jun 5, 2018

I'm going to close this PR and prepare one to revert the schema change.
The schema changes should be led by the broker, not the other way around.

@jrha jrha closed this Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned21 ned21 ned21 requested changes

@jrha jrha jrha approved these changes

@urbonegi urbonegi Awaiting requested review from urbonegi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jouvin @jrha @ned21