Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-openstack: add CloudKitty rating service #1393

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

alvarosimon
Copy link
Member

NOTE: This PR requires ceilometer service. #1383 should be reviewed/merged first.

More info:
https://wiki.openstack.org/wiki/CloudKitty

@alvarosimon alvarosimon changed the title ncm-openstack: add CloudKitty rating service [WIP] ncm-openstack: add CloudKitty rating service Aug 20, 2019
@alvarosimon alvarosimon changed the title [WIP] ncm-openstack: add CloudKitty rating service ncm-openstack: add CloudKitty rating service Aug 29, 2019
@jrha jrha added this to the 20.2 milestone Nov 28, 2019
@apdibbo
Copy link
Contributor

apdibbo commented Dec 5, 2019

This one also looks good to me

apdibbo
apdibbo previously approved these changes Dec 5, 2019
Copy link
Contributor

@apdibbo apdibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@jrha jrha modified the milestones: 20.2, 19.12 Dec 5, 2019
@jrha
Copy link
Member

jrha commented Dec 5, 2019

Rebased to avoid conflicts now that #1383 has been merged.

Copy link
Contributor

@apdibbo apdibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@jrha jrha merged commit 04565a5 into quattor:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ncm-openstack: add cloudkitty support
3 participants