Revert /system/archetype/os changes #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrha
changed the title
This was referenced Jun 5, 2018
Closed
|
I'd like to just keep this PR as a reversion, combining changes is what got us into this mess. |
|
I agree. It was my point. We should reverse the "mess" first and rebase #177 on it rather than the opposite... |
ned21
approved these changes
Jun 5, 2018
|
Shall I merge? |
jouvin
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were included as part of #142, but were not necessary for that use-case. The impact of these changes was underestimated and as the new types appear to be unused in the community the change should be reverted ASAP.
Fixes #179.
Fixes quattor/aquilon#93.