Merge pull request #90 from jouvin/cvmfs

cvmfs: use PKG_VERSION_xxx to test pkg_compare_version() return values
quattor · Nov 22, 2016 · beb6af4 · beb6af4
2 parents 038f4a8 + 394528f
commit beb6af4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/features/cvmfs/client.pan b/features/cvmfs/client.pan
@@ -99,7 +99,7 @@ include { 'repository/config/cvmfs' };
 #
 include 'quattor/functions/package';
 '/software/components/chkconfig/service' = {
-    if ((pkg_compare_version('2.1', CVMFS_CLIENT_VERSION) == -1) && ! is_defined(SELF['cvmfs'])) {
+    if ((pkg_compare_version('2.1', CVMFS_CLIENT_VERSION) == PKG_VERSION_GREATER) && ! is_defined(SELF['cvmfs'])) {
         SELF['cvmfs'] = nlist('on', '', 'startstop', false);
     };
     SELF;

diff --git a/features/cvmfs/rpms.pan b/features/cvmfs/rpms.pan
@@ -5,10 +5,10 @@ unique template features/cvmfs/rpms;
 include 'quattor/functions/package';
 
 '/software/packages' = {
-  if ((pkg_compare_version(CVMFS_CLIENT_VERSION, '2.1.20') >= 0) && (OS_VERSION_PARAMS['major'] != 'sl5')) {
-    SELF[escape('cvmfs-config-default')] = dict();
-  } else {
+  if ((pkg_compare_version(CVMFS_CLIENT_VERSION, '2.1.20') == PKG_VERSION_LESS) || (OS_VERSION_PARAMS['major'] == 'sl5')) {
     SELF[escape('cvmfs-keys')] = dict();
+  } else {
+    SELF[escape('cvmfs-config-default')] = dict();
   };
   SELF;
 };