Fix target_link_libraries in setup_arduino_library() #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of cmake (2.8.12 and later) warn about
policy CMP0022 (and CMP0038) regarding self-linking targets.
Removing ${LIB_TARGETS} from the inner target_link_libraries()
call fixes this.
Signed-off-by: Chris Evich <[email protected]>
|
There is a better fix for this in #143 |
|
good deal, closing this then in favour of #143 then, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of cmake (2.8.12 and later) warn about
policy CMP0022 (and CMP0038) regarding self-linking targets.
Removing ${LIB_TARGETS} from the inner target_link_libraries()
call fixes this.
Signed-off-by: Chris Evich [email protected]