Skip to content

Adding config option for ResetSeqTime #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile.dev
Original file line number Diff line number Diff line change
@@ -1 +1 @@
FROM mcr.microsoft.com/devcontainers/go:1.21
FROM mcr.microsoft.com/devcontainers/go:1.23
11 changes: 11 additions & 0 deletions config/configuration.go
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,17 @@ const (
// - Y
// - N
ResetOnDisconnect string = "ResetOnDisconnect"

// ResetSeqTime determines a time which a logon with a seqnum reset will be sent while keeping the session connected.
//
// Required: No
//
// Default: N/A
//
// Valid Values:
// - 00:00:00
// - A time in the format of HH:MM:SS, time is represented in time zone configured by TimeZone
ResetSeqTime string = "ResetSeqTime"
)

const (
Expand Down
2 changes: 2 additions & 0 deletions internal/session_settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ type SessionSettings struct {
SkipCheckLatency bool
MaxLatency time.Duration
DisableMessagePersist bool
ResetSeqTime TimeOfDay
EnableResetSeqTime bool

// Required on logon for FIX.T.1 messages.
DefaultApplVerID string
Expand Down
1 change: 1 addition & 0 deletions session.go
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,7 @@ func (s *session) run() {

case now := <-ticker.C:
s.CheckSessionTime(s, now)
s.CheckResetTime(s, now)
}
}
}
20 changes: 20 additions & 0 deletions session_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,26 @@ func (f sessionFactory) newSession(
}
}

if settings.HasSetting(config.ResetSeqTime) {
var seqTimeStr string
if seqTimeStr, err = settings.Setting(config.ResetSeqTime); err != nil {
return
}

var seqTime internal.TimeOfDay
if seqTime, err = internal.ParseTimeOfDay(seqTimeStr); err != nil {
err = errors.Wrapf(
err, "problem parsing time of day '%v' for setting '%v",
settings.settings[config.StartTime], config.StartTime,
)
return
}
s.EnableResetSeqTime = true
s.ResetSeqTime = seqTime
} else {
s.EnableResetSeqTime = false
}

if settings.HasSetting(config.TimeStampPrecision) {
var precisionStr string
if precisionStr, err = settings.Setting(config.TimeStampPrecision); err != nil {
Expand Down
9 changes: 9 additions & 0 deletions session_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@ func (sm *stateMachine) CheckSessionTime(session *session, now time.Time) {
}
}

func (sm *stateMachine) CheckResetTime(session *session, now time.Time) {
if session.EnableResetSeqTime {
ts := internal.NewTimeOfDay(now.Clock())
if session.ResetSeqTime == ts {
session.sendLogonInReplyTo(true, nil)
}
}
}

func (sm *stateMachine) setState(session *session, nextState sessionState) {
if !nextState.IsConnected() {
if sm.IsConnected() {
Expand Down
25 changes: 25 additions & 0 deletions session_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1001,3 +1001,28 @@ func (suite *SessionSendTestSuite) TestDropAndSendDropsQueueWithReset() {
suite.LastToAdminMessageSent()
suite.NoMessageSent()
}

func (s *SessionSuite) TestSeqNumResetTime() {
s.MockApp.On("ToAdmin")
s.SetupTest()

now := time.Now().UTC()
s.session.ResetSeqTime = internal.NewTimeOfDay(now.Clock())
s.session.EnableResetSeqTime = true

s.IncrNextSenderMsgSeqNum()
s.IncrNextTargetMsgSeqNum()

s.MockApp.On("ToAdmin")

s.IncrNextSenderMsgSeqNum()
s.IncrNextTargetMsgSeqNum()

s.MockApp.On("ToAdmin")

s.session.CheckResetTime(s.session, now)

s.NextSenderMsgSeqNum(2)
s.NextSenderMsgSeqNum(2)

}
Loading