Repository navigation
Conversation
js_parse_skip_parens_token() decides whether '/' starts a regexp from
the previous token, and is_regexp_allowed() did not list TOK_TEMPLATE.
After a complete template literal the '/' is a division, but it was
scanned as a regexp that hid the rest of the parenthesized list, so
`(a = `8` / 2) => a` failed with "expecting ';'". When the bogus
regexp was unterminated, as in `(`t` / 2)`, the expression was
evaluated correctly but a deferred "unexpected line terminator in
regexp" SyntaxError was left pending and reported after the script
ran (the same symptom as the private field case fixed earlier).
Treat a complete template as an operand. A template part ending in
'${' is followed by an expression, where a regexp may start, so it is
handled like '('.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js_parse_skip_parens_token() decides whether '/' starts a regexp from
the previous token, and is_regexp_allowed() did not list TOK_TEMPLATE.
After a complete template literal the '/' is a division, but it was
scanned as a regexp that hid the rest of the parenthesized list, so
(a =8/ 2) => afailed with "expecting ';'". When the bogusregexp was unterminated, as in
(t/ 2), the expression wasevaluated correctly but a deferred "unexpected line terminator in
regexp" SyntaxError was left pending and reported after the script
ran (the same symptom as the private field case fixed earlier).
Treat a complete template as an operand. A template part ending in
'${' is followed by an expression, where a regexp may start, so it is
handled like '('.
Fixes #1886