Repository navigation
Conversation
The parser seals template objects with seal_template_obj(): the elements are non-writable and non-configurable, `length` is made read-only and the object non-extensible. JS_WriteArray() stores them as BC_TAG_TEMPLATE_OBJECT, but JS_ReadArray() only called JS_PreventExtensions(), so `length` stayed writable and Object.isFrozen() of a tagged template's strings (and of its `raw` array) was false in code loaded from bytecode (qjs -c, qjsc, bjson), although GetTemplateObject freezes both. Use seal_template_obj() when reading them too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser seals template objects with seal_template_obj(): the
elements are non-writable and non-configurable,
lengthis maderead-only and the object non-extensible. JS_WriteArray() stores them as
BC_TAG_TEMPLATE_OBJECT, but JS_ReadArray() only called
JS_PreventExtensions(), so
lengthstayed writable andObject.isFrozen() of a tagged template's strings (and of its
rawarray) was false in code loaded from bytecode (qjs -c, qjsc, bjson),
although GetTemplateObject freezes both.
Use seal_template_obj() when reading them too.
Fixes #1888