Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #12: implement DataSourceWithLogsContextSupport interface #23

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Issue #12: implement DataSourceWithLogsContextSupport interface #23

merged 8 commits into from
Nov 24, 2023

Conversation

idrissneumann
Copy link
Collaborator

No description provided.

@idrissneumann idrissneumann marked this pull request as draft November 16, 2023 17:19
@idrissneumann idrissneumann force-pushed the feat_log_context branch 2 times, most recently from 8caca9f to ff37190 Compare November 22, 2023 14:03
@idrissneumann idrissneumann marked this pull request as ready for review November 22, 2023 14:04
@idrissneumann idrissneumann mentioned this pull request Nov 22, 2023
Closed
@idrissneumann idrissneumann force-pushed the feat_log_context branch 2 times, most recently from af4eabb to b56d712 Compare November 22, 2023 14:33
@idrissneumann idrissneumann force-pushed the feat_log_context branch 2 times, most recently from 4388c39 to 9b2de7b Compare November 23, 2023 08:41
fmassot
fmassot reviewed Nov 23, 2023
View reviewed changes
fmassot
fmassot reviewed Nov 23, 2023
View reviewed changes
@idrissneumann idrissneumann force-pushed the feat_log_context branch 2 times, most recently from 3e621fe to ecb52ac Compare November 23, 2023 13:39
fmassot
fmassot reviewed Nov 23, 2023
View reviewed changes
fmassot
fmassot approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@fmassot fmassot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if there are some tests that we can retrieve from the elasticsearch plugin?
it seems we're a bit light on this.

I put a few minor comments, can you fix that before merging?

@idrissneumann idrissneumann mentioned this pull request Nov 24, 2023
Closed
@idrissneumann
Copy link
Collaborator Author

Can you check if there are some tests that we can retrieve from the elasticsearch plugin?
it seems we're a bit light on this.

Yeah there's more asserts on the elastic plugin but the code is diverging, there's some typing/object structure divergences:

Screenshot 2023-11-24 at 10 08 57

@idrissneumann idrissneumann merged commit 271eda2 into main Nov 24, 2023
@ddelemeny ddelemeny deleted the feat_log_context branch April 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassot fmassot fmassot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idrissneumann @fmassot