Skip to content

Use AND as default operator, fixes #54 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/quickwit/client/models.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,16 @@ type QueryStringFilter struct {
Filter
Query string
AnalyzeWildcard bool
DefaultOperator string
}

// MarshalJSON returns the JSON encoding of the query string filter.
func (f *QueryStringFilter) MarshalJSON() ([]byte, error) {
// FIXME: readd analyze_wildcard when quickwit supports it.
root := map[string]interface{}{
"query_string": map[string]interface{}{
"query": f.Query,
"query": f.Query,
"default_operator": f.DefaultOperator,
// "analyze_wildcard": f.AnalyzeWildcard,
},
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/quickwit/client/search_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -257,14 +257,15 @@ func (b *FilterQueryBuilder) AddDateRangeFilter(timeField string, lteMillisecs i
}

// AddQueryStringFilter adds a new query string filter
func (b *FilterQueryBuilder) AddQueryStringFilter(querystring string, analyseWildcard bool) *FilterQueryBuilder {
func (b *FilterQueryBuilder) AddQueryStringFilter(querystring string, analyseWildcard bool, defaultOperator string) *FilterQueryBuilder {
if len(strings.TrimSpace(querystring)) == 0 {
return b
}

b.filters = append(b.filters, &QueryStringFilter{
Query: querystring,
AnalyzeWildcard: analyseWildcard,
DefaultOperator: defaultOperator,
})
return b
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/quickwit/client/search_request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func TestSearchRequest(t *testing.T) {
b.Sort(SortOrderDesc, timeField, "epoch_nanos_int")
filters := b.Query().Bool().Filter()
filters.AddDateRangeFilter(timeField, 1684398201000, 1684308201000)
filters.AddQueryStringFilter("test", true)
filters.AddQueryStringFilter("test", true, "AND")

t.Run("When building search request", func(t *testing.T) {
sr, err := b.Build()
Expand Down
2 changes: 1 addition & 1 deletion pkg/quickwit/data_query.go
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ func (e *elasticsearchDataQuery) processQuery(q *Query, ms *es.MultiSearchReques
b.Size(0)
filters := b.Query().Bool().Filter()
filters.AddDateRangeFilter(defaultTimeField, to, from)
filters.AddQueryStringFilter(q.RawQuery, true)
filters.AddQueryStringFilter(q.RawQuery, true, "AND")

if isLogsQuery(q) {
processLogsQuery(q, b, from, to, defaultTimeField)
Expand Down