support compressed data #4506
Merged
support compressed data #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
compressed_http
branch
from
2027981 to
693c9e9
Compare
fulmicoton
reviewed
Feb 5, 2024
quickwit/rest-api-tests/run_tests.py
Outdated
| kvargs["data"] = load_data(body_from_file) | ||
| kvargs["data"] = open(body_from_file, 'rb').read() | ||
| if body_from_file.endswith("gz"): | ||
| kvargs.setdefault("headers")["content-encoding"] = "gzip" |
There was a problem hiding this comment.
can we add a test with a gzip body?
There was a problem hiding this comment.
The test already has gzip data (gharchive-bulk.json.gz), I just deactivated the client side decompression
fulmicoton
reviewed
Feb 5, 2024
| /// searchable, so the second approach is more suitable for this use case. | ||
| async fn decompress_body(encoding: Option<String>, body: Bytes) -> Result<Bytes, warp::Rejection> { | ||
| match encoding.as_deref() { | ||
| Some("gzip" | "x-gzip") => { |
There was a problem hiding this comment.
can we improve this and make sure we return a 400 or a 406 with an error message for these errors. Right now all of them end up as a 500.
PSeitz
force-pushed
the
compressed_http
branch
from
28a4a98 to
619a964
Compare
PSeitz
force-pushed
the
compressed_http
branch
from
619a964 to
d8a2102
Compare
PSeitz
force-pushed
the
compressed_http
branch
from
d8a2102 to
e227ac4
Compare
fulmicoton
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3990
#4215