Merged
Conversation
TobiasFella
previously approved these changes
Feb 4, 2026
KitsuneRal
requested changes
Feb 4, 2026
Member
KitsuneRal
left a comment
KitsuneRal
left a comment
There was a problem hiding this comment.
Overall totally agree - with one suggestion.
This fixes a nasty issue in the QML module, because this wasn't scoped it was only accessible at the name level (e.g. Quotient.Invite) There were various other issues because of the similar names between Membership and other enums, so I stuck RegisterEnumClassesUnscoped on the namespace too. This does consitute an API change, but clients should be able to make this backwards-compatible with older libquotient versions.
redstrate
force-pushed
the
work/redstrate/fix-joinrule-scoping
branch
from
8e7c1fd to
0c27226
Compare
KitsuneRal
approved these changes
Feb 6, 2026
KitsuneRal
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a nasty issue in the QML module, because this wasn't scoped it was only accessible at the name level (e.g. Quotient.Invite) There were various other issues because of the similar names between Membership and other enums, so I stuck RegisterEnumClassesUnscoped on the namespace too.
This does consitute an API change, but clients should be able to make this backwards-compatible with older libquotient versions.