Change membersLeft from a QList to a QSet#956
Merged
KitsuneRal merged 1 commit intodevfrom Feb 14, 2026
Merged
Conversation
|
Member
|
Wow - I did not expect |
KitsuneRal
requested changes
Feb 13, 2026
I noticed in a profiling flamegraph that this was an outsized part during preprocessStateEvent, because we kept calling removeOne which performs an expensive search. In a quick test on my account, the list was in the magnitudes of hundreds of items big. And then there could be multiple rooms like that... Anyway this is an easy win for QSet, which has a faster lookup compared to QList.
redstrate
force-pushed
the
work/redstrate/members-left-perf-win
branch
from
cbd6d8a to
8c82b79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in a profiling flamegraph that this was an outsized part during preprocessStateEvent, because we kept calling removeOne which performs an expensive search. In a quick test on my account, the list was in the magnitudes of hundreds of items big. And then there could be multiple rooms like that...
Anyway this is an easy win for QSet, which has a faster lookup compared to QList.