This repository was archived by the owner on Nov 16, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 292
Markup cleanup #118
Open
unthunk
wants to merge
7
commits into
quri:master
Choose a base branch
from
unthunk:markup-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Markup cleanup #118
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7aca80b
Added dependency for eonasdan-bootstrap-datetimepicker
unthunk 8118ee2
Cleaned up markup in examples/basic/index.html
unthunk 7c8f41f
Added data attrs used on eonasdan-bootstrap-datetimepicker for stylin…
unthunk 5122909
Updated picker-switch markup for parity with eonasdan-bootstrap-datet…
unthunk baa26df
Updated widget to always use relative positioning for parent wrapper …
unthunk c6956cf
Fixes for tests
unthunk dced0e2
This file belongs in a different branch
unthunk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like because you removed the minified version, this won't work anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you are referring to being removed? If you mean the style sheet it was replaced with the current one from eonasdan-bootstrap-datetimepicker in commit 7aca80be75649f4987f0b62b61f61646ef63dd34.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad I didn't look at github's diff correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, no prob.