Fix state transfer not working for GRAPE and CRAB

[rochisha0]

This PR adds check when Hamiltonian is operator and passes dyn_type as UNIT for state transfer
Also fixes the checks for open systems
Fixes #34

[coveralls]

Pull Request Test Coverage Report for Build 14114330842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 14 of 31 (45.16%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-1.4%) to 86.59%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/qutip_qoc/pulse_optim.py	14	31	45.16%

Totals
Change from base Build 13404420638:	-1.4%
Covered Lines:	833
Relevant Lines:	962

---

💛 - Coveralls

[pmenczel]

Thank you Rochisha,

I just ran the notebook in #34 again, and the problem still seems to be the same. Am I doing something wrong?

[rochisha0]

@pmenczel I'll check again.

[pmenczel]

@rochisha0 I am very sorry, I was using the wrong conda environment. It seems to be working, I will give it a closer look when I have time.

[nwlambert]

just a note, lets chat a bit later today before merging this, I am a bit worried it conflicts with the operator->operator control examples (in the sense of optimizing unitaries/propagators)

[pmenczel]

Argh, sorry, Neill is right.

[pmenczel]

Thank you for the update, I have just a few QOL things to add

[pmenczel]

To make everything a bit easier to read and maintain, could we refactor a little bit so that this whole block of code becomes, for example

for objective in objectives:
    if objective._is_open():
        objective._format_for_open(optimization_type)

Without changing any of the logic; the logic seems good to me :)

[rochisha0]

I have refactored in a different way. Can you please check that, or explain this way more?

[pmenczel]

Thank you, it seems to be working now in all notebooks that I tested. I will merge the PR.

@rochisha0 @ajgpitch This means that once the QTRL-release is done, QOC is ready to make a release as well.