Add ENR JC Chain to v4 & v5 tutorials #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwlambert
requested changes
Oct 9, 2024
There was a problem hiding this comment.
thanks max, its looking good. i have a few minor comments.
for the enr_ptrace, yeah would be better if we can incorporate this into the normal ptrace itself, support data layer, etc. but we can do that later, alongside those additional enr functions, and with some help from eric
btw, the tests are failing for some broken link in another notebook, boxi and rushi were maybe gonna fix it
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Show resolved
Hide resolved
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Show resolved
Hide resolved
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Outdated
Show resolved
Hide resolved
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Outdated
Show resolved
Hide resolved
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Outdated
Show resolved
Hide resolved
tutorials-v5/miscellaneous/excitation-number-restricted-states-jc-chain.md
Show resolved
Hide resolved
|
It all looks good to me! Not much we can do about the failing tests, I will just merge. |
|
decided to get the tests working before merging, we can update the branch and hopefully just check the pep8 checks and the tests work |
- Added old enr state notebook from _qutip-notebooks_ and did changes as listed below - Rewrote description to add details about the physics - Fixed errors that came from the new version - Cleared up code - Added Markdown structure
- removed regular notebook file
- and me as an author (:
- added notebook - fixed errors that resulted from version change
- removed unused packages and variables - fixed typos and incorrect formatting of md
- added examples that commutation is no preserved - v5 test more concise
Langhaarzombie
force-pushed
the
feature/enr_states
branch
from
20f3a75 to
c377071
Compare
- replaced %time with qutip internal time measurement - shortened many lines - fixed typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Excitation Number Restricted (ENR) example to the tutorials for v4 and v5. The original notebook can be found here. It was previously not mentioned on the webiste.
Note: @nwlambert wanted to take a second look at the partial trace function. Its implementation in the notebook can probably be improved.