-
Notifications
You must be signed in to change notification settings - Fork 50
QuTiPv5 Paper Notebook: Non-Markovian mcsolve #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nwlambert
merged 17 commits into
qutip:main
from
Langhaarzombie:feature/ntbk_nm-mcsolve
May 22, 2025
Merged
QuTiPv5 Paper Notebook: Non-Markovian mcsolve #117
nwlambert
merged 17 commits into
qutip:main
from
Langhaarzombie:feature/ntbk_nm-mcsolve
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replicated plots from paper - added introduction and explanations in own words - added general structure for notbeook such as about, etc.
- added tests relying on proximity of the solutions - rewrote instructions so they are less like the paper and more clear - fixed typos and improved code structure
Contributor
Author
|
Although it is ready for review, we should still wait until an official arXiv link is available to the QuTiP 5 paper as this reference link is blank at the moment.
|
pmenczel
approved these changes
Dec 2, 2024
Member
pmenczel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side (however, let's wait with merging)
nwlambert
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the non-Markovian Monte Carlo examples from the paper to the tutorials. Essentially, it includes the damped Jaynes-Cumming model and the comparison of nm_mcsolve with HEOM and brsolve.
TODO: