Updating HEOM tutorials to use the new Enviroments #131
+1,205
−1,648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Paul <[email protected]>
nwlambert
reviewed
Apr 26, 2025
There was a problem hiding this comment.
thanks for these updates, and the new fitting PR, looks great. I guess 1d is the now the main demonstration of the new fitting options? it does make it a bit big, but I think splitting it would not be so useful, since its all the same example. my only suggestion really is it would be cool to have some examples showing where each of the different fitting options shine or are most efficient in their own niche. i guess thats quite a big task, so perhaps add it to a future todo list somewhere for someone :)
| (1 / np.pi) * alpha * wc**(1 - s) * beta**(-(s + 1)) * mp.gamma(s + 1) | ||
| ) | ||
| corr = (1 / np.pi) * alpha * wc ** (1 - s) | ||
| corr *= beta ** (-(s + 1)) * mp.gamma(s + 1) |
There was a problem hiding this comment.
you mention in qutip/qutip#2594 that there was an error in the c(t) for the ohmic class, is it also here? if so maybe good chance to update it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes #72 and updates tutorials to use qutip/qutip#2594
Note that using nbqa black notebook.ipynb as indicated in the read me introduced quite a few changes on the already existing code.