Fix macOS cross-compilation in PPM; add missing yaml dummy package#874
Merged
Conversation
During cross-compilation, install_dummies() installs minimal stub packages to satisfy R's dependency checks without needing to load shared libraries. yaml was missing from the set of dummies, causing keyring (which Imports yaml) to fail during cross-compilation because R couldn't find yaml on the library path. Add a dummy yaml package following the same pattern as the other dummies (cli, curl, desc, filelock, jsonlite, lpSolve, pkgbuild, pkgcache, ps, zip).
Member
|
Thanks! Previously this was tested implicitly because the nightly aarch64 linux builds were cross-compiled. But not any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PPM currently fails to build
pakfor macOS due to this cross-compilation specific issue withyaml:It appears that
yamlwas just missing from the set of dummy libraries added for cross-compilation, so this adds it using the same pattern as the other dummy packages.Also adds a test to catch missing dummy libraries in the future, but it's kind of a hack. I'm happy to leave it out or try a different way of testing this if you have any good ideas.