Introduce use_github_pages() and use_tidy_pkgdown() #1271
Conversation
jennybc
force-pushed
the
use-github-pages
branch
from
7ee5aad to
9eb08a4
Compare
jennybc
force-pushed
the
use-github-pages
branch
from
9eb08a4 to
ec52595
Compare
jennybc
changed the title
|
@hadley Is this what you had in mind? |
hadley
left a comment
hadley
left a comment
There was a problem hiding this comment.
This looks great! It's above and beyond what I was expecting, and I can see that it's going to save a bunch time and protect us against many minor mistakes when creating websites.
R/pkgdown.R
Outdated
| #' | ||
| #' @rdname tidyverse | ||
| #' @export | ||
| use_tidy_pkgdown <- function(cname = NULL) { |
There was a problem hiding this comment.
Just occurred to me: should we say something about tidytemplate for sites tidyverse org? Or maybe it's not worth it, given adding a new tidyverse package is a relatively rare occurrence.
There was a problem hiding this comment.
I think it's possible we should offer ourselves better templating for pkgdown config, but I definitely would not get into that here in this PR or, probably for v2.0.0.
| Remotes: | ||
| r-lib/gert, | ||
| r-lib/gh | ||
| r-lib/gh#139 |
There was a problem hiding this comment.
This is going to fail as soon as the PR is closed. It's a bit safer (but not as descriptive) to refer to a branch with the @branch notation instead.
There was a problem hiding this comment.
I don't plan for this situation to last very long, but yes you're right.
There was a problem hiding this comment.
Both are going to break when we merge and delete the branch. I'll update this as soon as we merge in gh.
Closes #224