Skip to content

Selenium suites: use RABBITMQ_ENABLED_PLUGINS over RABBITMQ_ENABLED_PLUGINS_FILE #13752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025

Conversation

MarcialRosales
Copy link
Contributor

gmake was ignoring RABBITMQ_ENABLED_PLUGINS_FILE. The majority of the suites were working because all plugins were enabled. But only when I wanted to specify just a few it did not work. It was always enabling all plugins.
With this change, the content of the file enabled_plugins in selenium is converted into the value of the env var RABBITMQ_ENABLED_PLUGINS.

This change is necessary for tanzu wsr testing.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

@MarcialRosales MarcialRosales self-assigned this Apr 15, 2025
@michaelklishin michaelklishin changed the title Use RABBITMQ_ENABLED_PLUGINS over RABBITMQ_ENABLED_PLUGINS_FILE Selenium suites: use RABBITMQ_ENABLED_PLUGINS over RABBITMQ_ENABLED_PLUGINS_FILE Apr 15, 2025
@MarcialRosales MarcialRosales force-pushed the use-env-var-list-plugins branch from 4913b3e to 8e23752 Compare April 24, 2025 10:19
@MarcialRosales MarcialRosales marked this pull request as ready for review April 24, 2025 11:03
@MarcialRosales MarcialRosales force-pushed the use-env-var-list-plugins branch from ce3429f to 9e69496 Compare April 25, 2025 12:23
@michaelklishin michaelklishin added this to the 4.2.0 milestone Apr 25, 2025
@michaelklishin michaelklishin merged commit 5bd8b3d into main Apr 25, 2025
268 of 271 checks passed
@michaelklishin michaelklishin deleted the use-env-var-list-plugins branch April 25, 2025 14:56
michaelklishin added a commit that referenced this pull request Apr 25, 2025
Selenium suites: use RABBITMQ_ENABLED_PLUGINS over RABBITMQ_ENABLED_PLUGINS_FILE (backport #13752)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants