Khepri: Clean up the setup/clustering code of the integration code #13781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumbbell
force-pushed
the
cleanup-rabbit_khepri
branch
from
6b92420 to
60accb9
Compare
[Why] The `rabbit_khepri` module grew during the work to add Khepri support to RabbitMQ and while Khepri was itself written. The current code is therefore unorganized. [How] This commit tries to sort the code that manages the setup of Khepri and the functions tha deal with the Khepri cluster. It also groups functions which provide support for CLI commands. It also adds documentation to several functions. Finally, when a node joins a cluster, we stop displaying the content of the Khepri tree.
dumbbell
force-pushed
the
cleanup-rabbit_khepri
branch
2 times, most recently
from
8ce85c8 to
fe17c62
Compare
dumbbell
force-pushed
the
cleanup-rabbit_khepri
branch
3 times, most recently
from
778c0d2 to
a9a2060
Compare
[Why] The `rabbit_khepri` module grew during the work to add Khepri support to RabbitMQ and while Khepri was itself written. The current code is therefore unorganized. [How] This commit tries to change proxy functions to be close to their Khepri equivalent. The module continues to set non-default options for write functions. We also add the variants that take an option map to be consistent and not have to deal with that in the future. Several legacy functions were removed, either because they were no longer called or because they were replace by a regular Khepri call.
dumbbell
force-pushed
the
cleanup-rabbit_khepri
branch
from
a9a2060 to
5300076
Compare
github-project-automation
bot
moved this from In Progress
to Done
in Khepri as the default metadata store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
rabbit_kheprimodule grew during the work to add Khepri support to RabbitMQ and while Khepri was itself written. The current code is therefore unorganized.How
The pull request has two commits: