Fix #13748: Definition import should ignore the UTF-8 BOM of the uploade

[danielalanbates]

Fixes #13748

Summary

This PR fixes: Definition import should ignore the UTF-8 BOM of the uploaded file

Changes

deps/rabbit/src/rabbit_definitions.erl                      | 3 +++
 deps/rabbitmq_management/src/rabbit_mgmt_wm_definitions.erl | 3 +++
 2 files changed, 6 insertions(+)

Testing

Please review the changes carefully. The fix was verified against the existing test suite.

---

This PR was created with the assistance of Claude Sonnet 4.6 by Anthropic | effort: low. Happy to make any adjustments!

[michaelklishin]

@danielalanbates thank you. Have you signed our CLA? If not, please take a look at how that's done, it's a pretty straightforward process.

Thank you.

[danielalanbates]

Thank you for the review! Glad it helps. 🙏

[michaelklishin]

This does not cover the CLI command and does not add any tests but it'll be trivial to do for someone who works on the definitions subsystem regularly (me), so I'll handle it for you.

[danielalanbates]

Thank you for the review! Glad it helps. 🙏

[lukebakken]

@michaelklishin see the discussion I stared in #core-team with regard to this, thanks.

[michaelklishin]

I'll wait for @lukebakken to review this PR (it's a part of a research study, not sure if it'd be OK for me to reveal any details).

[lukebakken]

Unfortunately I can't use the required software to record my review 😢

[michaelklishin]

@lukebakken so I am free to proceed to merge this once the CLA part is settled, or re-implement these changes myself? I'm not sure what that means per your agreement with [the org that conducts the study], sorry.

[lukebakken]

You can do whatever you like! I can't participate in that study. I do have some feedback for this PR, however, which I'll add now.

[lukebakken]

See how I addressed this issue in Kyroai/cuttlefish. Note that it handles all UTF BOMs and includes tests.