Skip to content

See #5957. HTTP api to generate hashed password from cleartext password (backport #7004) #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deps/rabbitmq_management/src/rabbit_mgmt_dispatcher.erl
Original file line number Diff line number Diff line change
Expand Up @@ -183,5 +183,6 @@ dispatcher() ->
{"/auth/attempts/:node", rabbit_mgmt_wm_auth_attempts, [all]},
{"/auth/attempts/:node/source", rabbit_mgmt_wm_auth_attempts, [by_source]},
{"/login", rabbit_mgmt_wm_login, []},
{"/config/effective", rabbit_mgmt_wm_environment, []}
{"/config/effective", rabbit_mgmt_wm_environment, []},
{"/auth/hash_password/:password", rabbit_mgmt_wm_hash_password, []}
].
36 changes: 36 additions & 0 deletions deps/rabbitmq_management/src/rabbit_mgmt_wm_hash_password.erl
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
%% This Source Code Form is subject to the terms of the Mozilla Public
%% License, v. 2.0. If a copy of the MPL was not distributed with this
%% file, You can obtain one at https://mozilla.org/MPL/2.0/.
%%
%% Copyright (c) 2007-2023 VMware, Inc. or its affiliates. All rights reserved.
%%

-module(rabbit_mgmt_wm_hash_password).

-export([init/2, to_json/2, content_types_provided/2, is_authorized/2]).
-export([variances/2, allowed_methods/2]).

-include_lib("rabbitmq_management_agent/include/rabbit_mgmt_records.hrl").
-include_lib("rabbit_common/include/rabbit.hrl").

%%--------------------------------------------------------------------

init(Req, _State) ->
{cowboy_rest, rabbit_mgmt_headers:set_common_permission_headers(Req, ?MODULE), #context{}}.

variances(Req, Context) ->
{[<<"accept-encoding">>, <<"origin">>], Req, Context}.

allowed_methods(ReqData, Context) ->
{[<<"GET">>, <<"OPTIONS">>], ReqData, Context}.

content_types_provided(ReqData, Context) ->
{rabbit_mgmt_util:responder_map(to_json), ReqData, Context}.

to_json(ReqData, Context) ->
Password = rabbit_mgmt_util:id(password, ReqData),
HashedPassword = rabbit_password:hash(Password),
rabbit_mgmt_util:reply([{ok, base64:encode(HashedPassword)}], ReqData, Context).

is_authorized(ReqData, Context) ->
rabbit_mgmt_util:is_authorized_admin(ReqData, Context).
14 changes: 13 additions & 1 deletion deps/rabbitmq_management/test/rabbit_mgmt_http_SUITE.erl
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ all_tests() -> [
users_legacy_administrator_test,
adding_a_user_with_password_test,
adding_a_user_with_password_hash_test,
adding_a_user_with_generated_password_hash_test,
adding_a_user_with_permissions_in_single_operation_test,
adding_a_user_without_tags_fails_test,
adding_a_user_without_password_or_hash_test,
Expand Down Expand Up @@ -143,7 +144,7 @@ all_tests() -> [
single_active_consumer_qq_test,
%% oauth_test, %% disabled until we are able to enable oauth2 plugin
disable_basic_auth_test,
login_test,
login_test,
csp_headers_test,
auth_attempts_test,
user_limits_list_test,
Expand Down Expand Up @@ -583,6 +584,17 @@ adding_a_user_with_password_hash_test(Config) ->
[?CREATED, ?NO_CONTENT]),
http_delete(Config, "/users/user11", ?NO_CONTENT).

adding_a_user_with_generated_password_hash_test(Config) ->
#{ok := HashedPassword} = http_get(Config, "/auth/hash_password/some_password"),

http_put(Config, "/users/user12", [{tags, <<"administrator">>},
{password_hash, HashedPassword}],
[?CREATED, ?NO_CONTENT]),
% If the get succeeded, the hashed password generation is correct
User = http_get(Config, "/users/user12", "user12", "some_password", ?OK),
?assertEqual(maps:get(password_hash, User), HashedPassword),
http_delete(Config, "/users/user12", ?NO_CONTENT).

adding_a_user_with_permissions_in_single_operation_test(Config) ->
QArgs = #{},
PermArgs = #{configure => <<".*">>,
Expand Down