bump rustc-ap crates to v705#1159
Merged
kngwyu merged 2 commits intoracer-rust:masterfrom Feb 8, 2021
Merged
Conversation
calebcartwright
commented
Feb 6, 2021
Comment on lines
-899
to
+904
| if let ItemKind::TyAlias(_, _, _, Some(ref ty)) = item.kind { | ||
| self.name = Some(item.ident.name.to_string()); | ||
| self.type_ = Ty::from_ast(&ty, self.scope); | ||
| debug!("typevisitor type is {:?}", self.type_); | ||
| if let ItemKind::TyAlias(ref ty_kind) = item.kind { | ||
| if let Some(ref ty) = ty_kind.3 { | ||
| self.name = Some(item.ident.name.to_string()); | ||
| self.type_ = Ty::from_ast(&ty, self.scope); | ||
| debug!("typevisitor type is {:?}", self.type_); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
rustc is going to box itemkind variants to reduce the memory footprint, and the updated rustc-ap crate versions pull in some of changes that have started down that path.
if you'd prefer, we could enable the box_patterns feature gate for some cleaner matching, but I elected to avoid doing so in this PR
kngwyu
approved these changes
Feb 8, 2021
Collaborator
kngwyu
left a comment
kngwyu
left a comment
There was a problem hiding this comment.
Thanks!
box_patterns could be better, but now this looks OK to me 👍🏼
Collaborator
|
Released 2.1.44 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately our last round of updating these crates to address the rust tool state issues (rust-lang/rust#81583 rust-lang/rust#81582) hit a roadblock as we got caught between the stabilization of
int_bits_constand the subsequent reversion.As such we're forced to restart the cycle, with v705 being the new crate version target. This version includes some upstream AST changes that had to be addressed here, commentary inline below
Also closes #1157