Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
|
There was a problem hiding this comment.
Function upload_file refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-92
to
+101
|
|
||
| if os.path.exists(file_path): | ||
| data = parse_yaml(file_path) | ||
|
|
||
| if raw: | ||
| return {'prompt': data.get('prompt')} | ||
| else: | ||
| return FileResponse(file_path, media_type='application/x-yaml') | ||
|
|
||
| else: | ||
|
|
||
| if not os.path.exists(file_path): | ||
| raise HTTPException(status_code=404, detail=f'File not found: {file_path}') | ||
| data = parse_yaml(file_path) | ||
|
|
||
| return ( | ||
| {'prompt': data.get('prompt')} | ||
| if raw | ||
| else FileResponse(file_path, media_type='application/x-yaml') | ||
| ) |
There was a problem hiding this comment.
Function read_file_by_name refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-113
to
+133
| map_info = {} | ||
| map_info = {'title': ask_for_input('title', 'str', True)} | ||
|
|
||
| map_info['title'] = ask_for_input('title', 'str', True) | ||
| map_info['uuid'] = str(uuid.uuid4()) | ||
| map_info['description'] = ask_for_input('description', 'str', True) | ||
| map_info['category'] = ask_for_input('category', 'str', True) | ||
| map_info['provider'] = ask_for_input('provider', 'str', False) | ||
| map_info['model'] = ask_for_input('model', 'str', False) | ||
|
|
||
| # model settings with default values | ||
| model_settings_fields = ['temperature', 'top_k', 'top_p', 'max_tokens', 'stream', 'presence_penalty', 'frequency_penalty'] | ||
| model_settings_types = ['float', 'int', 'float', 'int', 'bool', 'float', 'float'] | ||
| model_settings_defaults = [0.8, None, 1, None, False, 0.0, 0.0] | ||
|
|
||
| model_settings = {field: ask_for_input(field, ftype, False, default) for field, ftype, default in zip(model_settings_fields, model_settings_types, model_settings_defaults)} | ||
|
|
||
| # only add model_settings to map if it's not empty | ||
| if any(model_settings.values()): | ||
| map_info['model_settings'] = model_settings | ||
|
|
||
| map_info['prompt'] = ask_for_input('prompt', 'str', True) | ||
|
|
There was a problem hiding this comment.
Function create_prompt refactored with the following changes:
- Merge dictionary assignment with declaration (
merge-dict-assign)
Comment on lines
-219
to
+218
|
|
There was a problem hiding this comment.
Lines 219-269 refactored with the following changes:
- Replace f-string with no interpolated values with string [×2] (
remove-redundant-fstring)
Comment on lines
-28
to
+43
|
|
||
| url = f'{self.base_url}/{repo_user}/{repo_name}/main/prompts/{full_prompt_name}.yml' | ||
| full_prompt_name = full_prompt_name + '.yml' if not full_prompt_name.endswith('.yml') else full_prompt_name | ||
| full_prompt_name = ( | ||
| f'{full_prompt_name}.yml' | ||
| if not full_prompt_name.endswith('.yml') | ||
| else full_prompt_name | ||
| ) | ||
|
|
||
| print(f'(status) retrieving template: {url}') | ||
|
|
||
| try: | ||
| response = requests.get(url) | ||
| if response.status_code != 200: | ||
| print(f'(error) error retrieving template - non 200 status code: {response.status_code}') | ||
| return prompt_data | ||
|
|
There was a problem hiding this comment.
Function PromptLoader.get_template refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!