Bugfix/remote uri path hyphen support (#2013)

* add unit test for hyphenated uri * add support for hyphenated uri in regex --------- Co-authored-by: Michael Bordash <[email protected]>
rackspace · Oct 19, 2023 · 1fa0fb0 · 1fa0fb0
1 parent 956acd6
commit 1fa0fb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/runway/core/components/_module_path.py b/runway/core/components/_module_path.py
@@ -37,7 +37,7 @@ class ModulePath:
     ARGS_REGEX: ClassVar[str] = r"(\?)(?P<args>.*)$"
     REMOTE_SOURCE_HANDLERS: ClassVar[Dict[str, Type[Source]]] = {"git": Git}
     SOURCE_REGEX: ClassVar[str] = r"(?P<source>[a-z]+)(\:\:)"
-    URI_REGEX: ClassVar[str] = r"(?P<uri>[a-z]+://[a-zA-Z0-9\./]+?(?=//|\?|$))"
+    URI_REGEX: ClassVar[str] = r"(?P<uri>[a-z]+://[a-zA-Z0-9\./-]+?(?=//|\?|$))"
 
     def __init__(
         self,

diff --git a/tests/unit/core/components/test_module_path.py b/tests/unit/core/components/test_module_path.py
@@ -37,6 +37,15 @@
 )
 
 TESTS: List[TypeDefTestDefinition] = [
+    {
+        "definition": "git::git://github.com/onicagroup/foo/foo-bar.git",
+        "expected": {
+            "location": "./",
+            "arguments": {},
+            "source": "git",
+            "uri": "git://github.com/onicagroup/foo/foo-bar.git",
+        },
+    },
     {
         "definition": "git::git://github.com/onicagroup/foo/bar.git",
         "expected": {