Fix for junit failure FIX #487 #488
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
+ Coverage 87.13% 87.41% +0.27%
==========================================
Files 38 38
Lines 2325 2329 +4
==========================================
+ Hits 2026 2036 +10
+ Misses 299 293 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
thanks for the detailed issue and mr looks good, i will review it in the next 3 weeks, if that doesn't happen feel free to ping me again |
|
Hi @fliiiix, just FYI, code coverage is not reaching the target and so failing. |
|
The coverage target thing can be ignored, this is a bit of a left over from the past, which is a bit to sensitive and fails even though things are still more than ok, but i haven't got around to figure out to make the job succeed on small negative coverage changes or to find a better coverage tool |
Run with: radish -b radish features --junit-xml=result.xml
Produces junit xml:
```
<?xml version='1.0' encoding='utf-8'?>
<testsuites time="0.000">
<testsuite name="Test summing numbers" failures="0" errors="0" skipped="1" tests="2" time="0.000">
<testcase classname="Test summing numbers" name="Sum two numbers" time="0.000"/>
<testcase classname="Test summing numbers" name="Sum three numbers" time="0.000">
<skipped/>
</testcase>
</testsuite>
<testsuite name="Test summing numbers" failures="0" errors="0" skipped="2" tests="2" time="0.000">
<testcase classname="Test summing numbers" name="Sum two numbers" time="0.000">
<skipped/>
</testcase>
<testcase classname="Test summing numbers" name="Sum three numbers" time="0.000">
<skipped/>
</testcase>
</testsuite>
</testsuites>
```
fliiiix
force-pushed
the
early_exit_junit_xml_feature
branch
from
828ee2c to
becca9c
Compare
| # IDE configuration | ||
| .idea/ | ||
| .venv/ | ||
| .vscode/ |
There was a problem hiding this comment.
@alexandrehassan you might want to look into your editor config and enable new line at the end of a file, https://stackoverflow.com/a/729795/1279355
|
Added a exploratory test, thanks @priyacshah for the MR and @alexandrehassan for adding a test ✨ |
3 participants
FIX #487
In the case of early exit, the features that dont' run after first failure do not have starttime or endtime. Fixed it to skip those after early exit.