Skip to content

Commit

Permalink
Address some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lrubasze committed Dec 10, 2024
1 parent 0d2b11b commit 8de4789
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions core-rust/mesh-api-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ It works only with the instructions constructed by Mesh.

Technically, it would be possible to use transaction previews, receipts, and balance change summaries to extract operations.
But we don't do it for following reasons:
- both endpoint methods should wotrk offline
- both endpoint methods should work offline
- both endpoint methods should be static (not affected by current state of the network)
- this approach is deemed too resource-heavy

## Configuration

### Server settings
There are 3 settings to configure Mesh API server, which allow to:
There are 3 configuration settings for a node's Mesh API server, which can:
- enable/disable Mesh API server launch (disabled by default),
- override the default port (3337),
- override the default bind address (127.0.0.1).
Expand All @@ -68,7 +68,7 @@ api.mesh.enabled=<true/false>
api.mesh.port=<port number>
api.mesh.bind_address=<ip address>
```
#### Node running in a Docker
#### Node running in Docker
Set below environmental variables

```plaintext
Expand All @@ -89,7 +89,7 @@ db.historical_substate_values.enable=<true/false>
state_hash_tree.state_version_history_length=<history_length_to_keep>
```

#### Node running in a Docker
#### Node running in Docker
```
RADIXDLT_DB_HISTORICAL_SUBSTATE_VALUES_ENABLE=<true/false>
RADIXDLT_STATE_HASH_TREE_STATE_VERSION_HISTORY_LENGTH=<history_length_to_keep>
Expand Down Expand Up @@ -149,7 +149,7 @@ http://localhost:3337/mesh/account/balance
RADIXDLT_NODE_KEY=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY= ./gradlew :core:run --info
```

- Node running in a Docker
- Node running in Docker

- Manual setup for production or testnet

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pub(crate) async fn handle_construction_combine(

let intent = IntentV1::from_raw(&raw).map_err(|err| {
ResponseError::from(ApiError::InvalidTransaction).with_details(format!(
"Failed to create transaction intent from raw: {:?}",
"Failed to create transaction intent v1 from raw: {:?}",
err
))
})?;
Expand Down

0 comments on commit 8de4789

Please sign in to comment.