fix: CI fixes

radixdlt · Feb 14, 2025 · cffdc46 · cffdc46
1 parent f64cbdf
commit cffdc46
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -253,14 +253,21 @@ jobs:
           path: ~/.gradle/caches
           key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
           restore-keys: ${{ runner.os }}-gradle
-      - name: Build and run node in the background
+      - name: Pre-build node
+        # We pre-build the node so that running it is fast in the below job, which means
+        # we can use the wait 2 minutes trick to wait for it to boot up so that we can
+        # move on to executing the API tests
+        run: ./gradlew :core:assemble
+      - name: Run node in the background
+        # We run the node in the background so we can run the CLI tests against it
         env:
           # This is to skip keygen step
           RADIXDLT_NODE_KEY: AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAY=
         run: |
           echo "db.historical_substate_values.enable=true" >> core/default.config
           ./gradlew :core:run --info &
       - name: Wait for 2 minutes
+        # This should be enough time for the node to boot up, as we have built it already
         run: sleep 2m
       - name: Install mesh-cli
         run: curl -sSfL https://raw.githubusercontent.com/coinbase/mesh-cli/master/scripts/install.sh | sh -s

diff --git a/core/src/test/java/com/radixdlt/rev2/protocol/CuttlefishProtocolUpdateTest.java b/core/src/test/java/com/radixdlt/rev2/protocol/CuttlefishProtocolUpdateTest.java
@@ -208,7 +208,8 @@ public void protocol_update_process_updates_status_summary() throws ApiException
                   .get()
                   .getNewValue()
                   .getSubstateData();
-      assertEquals(ProtocolConfig.CUTTLEFISH_PART2_PROTOCOL_VERSION_NAME, latestStatus.getProtocolVersion());
+      assertEquals(
+          ProtocolConfig.CUTTLEFISH_PART2_PROTOCOL_VERSION_NAME, latestStatus.getProtocolVersion());
       assertEquals(ProtocolUpdateStatusType.COMPLETE, latestStatus.getUpdateStatus().getType());
     }
   }