Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh reconciliation tests support #1036

Merged
merged 26 commits into from
Dec 10, 2024
Merged

Conversation

lrubasze
Copy link
Contributor

@lrubasze lrubasze commented Nov 28, 2024

  • Assure mesh-cli reconciliation tests are passing
    • Add FeePayment operation
    • Add historical balances support
  • Add mesh-cli configs for stokenet and mainnet
  • Support operations in /mempool/transaction endpoint
  • Add README

Copy link

Phylum Report Link

Copy link

github-actions bot commented Nov 28, 2024

Docker tags
docker.io/radixdlt/private-babylon-node:pr-1036
docker.io/radixdlt/private-babylon-node:91c212e4ca
docker.io/radixdlt/private-babylon-node:sha-91c212e

@lrubasze lrubasze force-pushed the feature/mesh-reconciliation branch from cf5d153 to 323538d Compare November 29, 2024 10:00
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 13.60000% with 324 lines in your changes missing coverage. Please review.

Project coverage is 40.7%. Comparing base (b8f3151) to head (8de4789).

Files with missing lines Patch % Lines
...-api-server/src/mesh_api/conversions/operations.rs 0.0% 130 Missing ⚠️
...pi-server/src/mesh_api/handlers/account_balance.rs 0.0% 61 Missing ⚠️
...pi-server/src/mesh_api/handlers/network_options.rs 0.0% 30 Missing ⚠️
...erver/src/mesh_api/handlers/mempool_transaction.rs 0.0% 26 Missing ⚠️
...ust/mesh-api-server/src/mesh_api/handlers/block.rs 0.0% 18 Missing ⚠️
...erver/src/mesh_api/handlers/construction_submit.rs 0.0% 13 Missing ⚠️
...rver/src/mesh_api/handlers/construction_combine.rs 0.0% 12 Missing ⚠️
...server/src/mesh_api/handlers/construction_parse.rs 0.0% 12 Missing ⚠️
...-server/src/mesh_api/handlers/construction_hash.rs 0.0% 11 Missing ⚠️
.../mesh-api-server/src/mesh_api/conversions/block.rs 0.0% 7 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             feature/mesh   #1036    +/-   ##
===============================================
  Coverage            40.7%   40.7%            
- Complexity           4624    4625     +1     
===============================================
  Files                1892    1892            
  Lines               57516   57691   +175     
  Branches             1527    1527            
===============================================
+ Hits                23415   23530   +115     
- Misses              33618   33679    +61     
+ Partials              483     482     -1     
Flag Coverage Δ
rust 40.7% <13.6%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sh-api-server/src/mesh_api/conversions/numerics.rs 89.0% <100.0%> (+89.0%) ⬆️
core-rust/mesh-api-server/src/mesh_api/errors.rs 0.0% <ø> (ø)
...api-server/src/mesh_api/handlers/network_status.rs 0.0% <ø> (ø)
core-rust/mesh-api-server/src/mesh_api/helpers.rs 0.0% <ø> (ø)
core-rust/mesh-api-server/src/mesh_api/metrics.rs 0.0% <ø> (ø)
...-api-server/src/mesh_api/conversions/addressing.rs 13.1% <0.0%> (+13.1%) ⬆️
...sh-api-server/src/mesh_api/conversions/currency.rs 0.0% <0.0%> (ø)
...ver/src/mesh_api/handlers/construction_payloads.rs 0.0% <0.0%> (ø)
...r/src/mesh_api/handlers/construction_preprocess.rs 0.0% <0.0%> (ø)
.../mesh-api-server/src/mesh_api/conversions/block.rs 0.0% <0.0%> (ø)
... and 9 more

... and 4 files with indirect coverage changes

@lrubasze lrubasze marked this pull request as ready for review November 29, 2024 10:44
@lrubasze lrubasze changed the title Mesh reconciliation Mesh reconciliation tests support Nov 29, 2024
Copy link
Contributor

@dhedey dhedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

A few small tweaks proposed, all quite minor.

Copy link

@lrubasze lrubasze merged commit 6cb8f0a into feature/mesh Dec 10, 2024
24 checks passed
@lrubasze lrubasze deleted the feature/mesh-reconciliation branch December 10, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants