Apply security shield on single entity TX Review #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
force-pushed
the
feature/ABW-4064-transaction-review-screen
branch
from
6d4007b to
0f2580d
Compare
giannis-rdx
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
minor: maybe to move this to signing package? or create a new one securityshields ?
There was a problem hiding this comment.
I think we need a specific package for profile related mutations.
| _state.update { state -> state.copy(isLoading = false) } | ||
| sendEvent(Event.ShieldApplied) | ||
|
|
||
| incomingRequestRepository.add(request) |
There was a problem hiding this comment.
just to be sure, this request gets requestHandled in the TransactionReviewViewModel, right?
There was a problem hiding this comment.
requestHandled is invoked either:
- when user dismisses the transaction
- by the tx status dialog.
sergiupuhalschi-rdx
approved these changes
Feb 14, 2025
| @@ -568,7 +568,7 @@ private fun UnsafeCombinationInfoDialog( | |||
| } | |||
|
|
|||
| @Composable | |||
| private fun TimePeriod.title(): String { | |||
| fun TimePeriod.title(): String { | |||
There was a problem hiding this comment.
nit: this composable should be moved to a common package
|
Keeping the PR open, to add a withdrawing box for securifying account. |
micbakos-rdx
force-pushed
the
feature/ABW-4064-transaction-review-screen
branch
from
b796d26 to
481d76f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes both the UI for showing the transaction summary for applying a security shield to an account or persona.
How to test
Make sure you have XRD in an account on your profile.
Video
slack