[ABW-4081] Security shields list #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giannis-rdx
force-pushed
the
feature/ABW-4081-security-shields-list
branch
from
970972a to
ed96778
Compare
giannis-rdx
requested review from
sergiupuhalschi-rdx and
micbakos-rdx
and removed request for
sergiupuhalschi-rdx
Comment on lines
96
to
97
| _state.update { state -> state.copy(isChangingMainSecurityShieldInProgress = false) } | ||
| onDismissMainSecurityShieldBottomSheet() |
There was a problem hiding this comment.
Is it possible that isChangingMainSecurityShieldInProgress = false could be inside onDismissMainSecurityShieldBottomSheet(). On that way you could save one less state update.
Comment on lines
83
to
86
| accountsCount = item.shieldForDisplay.numberOfLinkedAccounts.toInt(), | ||
| personasCount = item.shieldForDisplay.numberOfLinkedPersonas.toInt(), | ||
| hasAnyHiddenEntities = item.shieldForDisplay.numberOfLinkedHiddenAccounts.toInt() != 0 || | ||
| item.shieldForDisplay.numberOfLinkedHiddenPersonas.toInt() != 0 |
There was a problem hiding this comment.
You could create some computed properties in the SecurityShieldCard for all these.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a list of security shields to the “Security Shields” screen. Each Security Shield card currently contains the following information:
Other operations in the screen:
What is missing (future task):
How to test
Video
here
PR submission checklist