Ret classification update #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
5
to
8
| // We favor more specific classifications. | ||
| // Also, RET started to put General classification first in the list, instead of last. | ||
| let firstNonGeneral = self.detailedClassification.first { $0 != .general } | ||
| return firstNonGeneral ?? self.detailedClassification.first |
There was a problem hiding this comment.
we should put this in Sargon
GhenadieVP
force-pushed
the
ret_classification_update
branch
from
66609ed to
35c1860
Compare
GhenadieVP
commented
Feb 14, 2025
| case nil: | ||
| return nil | ||
|
|
||
| case .securifyEntity: | ||
| return nil |
matiasbzurovski
approved these changes
Feb 14, 2025
CyonAlexRDX
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration for radixdlt/sargon#373