Main Security Shield updates #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 1190 1192 +2
Lines 26861 26876 +15
Branches 85 85
=======================================
+ Hits 24896 24910 +14
- Misses 1954 1955 +1
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CyonAlexRDX
reviewed
Feb 10, 2025
CyonAlexRDX
approved these changes
Feb 10, 2025
matiasbzurovski
approved these changes
Feb 10, 2025
...es/uniffi/uniffi_SPLIT_ME/src/profile/mfa/security_structures/security_structure_metadata.rs
Outdated
Show resolved
Hide resolved
crates/profile/logic/logic_SPLIT_ME/src/logic/profile_security_structure.rs
Outdated
Show resolved
Hide resolved
giannis-rdx
reviewed
Feb 11, 2025
There was a problem hiding this comment.
imo this can go under the app_preferences/security_structures/
giannis-rdx
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainif no main shield existsis_MainfromSecurityStructureMetadatato hostssecurity_structure_of_factor_source_ids_by_security_structure_idto hosts