Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: include DataType in CategoricalEltypes #876

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

tiemvanderdeure
Copy link
Collaborator

Does what it says on the tin :)

Specifically designed to make using RasterDataSources climate types as lookups (as in rafaqz/Rasters.jl#826) even more slick.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (a5585f5) to head (8636f9c).
Report is 40 commits behind head on breaking.

Additional details and impacted files
@@             Coverage Diff              @@
##           breaking     #876      +/-   ##
============================================
+ Coverage     83.66%   84.64%   +0.98%     
============================================
  Files            47       50       +3     
  Lines          4653     4683      +30     
============================================
+ Hits           3893     3964      +71     
+ Misses          760      719      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rafaqz
Copy link
Owner

rafaqz commented Dec 3, 2024

Does what it says on the tin :)

Oh no it's spreading 😂

But yes, great idea. Technically breaking I guess as it's changing the returned type, so let's lump this with another break

@rafaqz rafaqz changed the title include DataType in CategoricalEltypes Breaking: include DataType in CategoricalEltypes Dec 3, 2024
@rafaqz rafaqz changed the base branch from main to breaking March 8, 2025 23:29
@rafaqz rafaqz merged commit cd83dfe into rafaqz:breaking Mar 8, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants