Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DimSelectors indexed with DimSelectors return DimSelectors #915

Merged
merged 4 commits into from
Jan 30, 2025
Merged

DimSelectors indexed with DimSelectors return DimSelectors #915

merged 4 commits into from
Jan 30, 2025

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Jan 29, 2025

Half of #914

Basically a small bug from dispatching on AbstractRange rather than AbstractArray

@rafaqz rafaqz mentioned this pull request Jan 30, 2025
Open
@rafaqz rafaqz merged commit a47db88 into main Jan 30, 2025
7 of 8 checks passed
@rafaqz rafaqz deleted the dimselect_returns_dimselect branch January 30, 2025 09:21
@tiemvanderdeure tiemvanderdeure mentioned this pull request Jan 30, 2025
Merged
@tiemvanderdeure
Copy link
Collaborator

This just broke indexing by DimensionalIndices

using DimensionalData
da = rand(X(1:10), Y(1:10))
ds = DimSelectors(da)
ds[(X(1),)]

@rafaqz
Copy link
Owner Author

rafaqz commented Jan 30, 2025

Uggh missing tests

@rafaqz
Copy link
Owner Author

rafaqz commented Jan 30, 2025

Fixed in #916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaqz @tiemvanderdeure